> Hi, > > the problem in PR 57084 is that late PRE devirtualization creates a > direct call to a decl fro which we only have an inlined call graph > mode in the given partition. I tried to find a most universal place > where to fix it because this problem is not special to type-based > devirtualization and in theory can be caused by any call to a decl > that is grabbed from a constructor. I think the best place is the > following one-liner, because all such decls should go through > canonicalize_constructor_val. > > Bootstrapped and tested on x86_64-linux, fixes the testcase (at -m32) > and I have happened to also LTO build Mozilla Firefox with it. OK for > trunk?
Is this change needed for 4.8, too? It would be OK there. For 4.9 I would preffer replacing cgraph_get_create by cgraph_get_create_real_symbol_node. I believe that all users of cgraph_get_create are not interested in inline nodes. I just did not want to make such intrusive change for 4.8... Honza
