On Thu, Apr 04, 2013 at 04:29:34PM +0200, Marek Polacek wrote:
> On Thu, Apr 04, 2013 at 04:20:36PM +0200, Marek Polacek wrote:
> > On Thu, Apr 04, 2013 at 04:06:35PM +0200, Jakub Jelinek wrote:
> > > In this second hunk the division is done only for flag_guess_branch_prob,
> > > so shouldn't it be
> > > if (flag_guess_branch_prob)
> > > {
> > > if (PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION) == 0
> > > || edge->frequency <= (CGRAPH_FREQ_BASE
> > > / PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION)))
> > > return false;
> > > }
> > > return true;
> > > instead?
> >
> > Yeah, I guess so. Thanks; fixed:
>
> Now really.
>
> 2013-04-04 Marek Polacek <pola...@redhat.com>
>
> PR tree-optimization/48186
> * predict.c (maybe_hot_frequency_p): Return false if
> HOT_BB_FREQUENCY_FRACTION is 0.
> (cgraph_maybe_hot_edge_p): Likewise.
>
> * gcc.dg/pr48186.c: New test.
Ok, if it passes bootstrap/regtest.
Jakub
