On 2013-03-13 18:16 , Steven Bosscher wrote:
Much better than what GCC has now, although I had hoped it'd be possible to build on the result of a previous expression without tree variables.
It may be possible, but we need something to tie the expressions together and the temporaries are the perfect glue. I tried coming up with some other referencing scheme, but this seemed the most natural. If you can think of anything simpler, let's do it.

What does your plan for this look like? Personally I'd prefer to keep CFG modifications explicit, not hidden behind this builder. CFG changes must be done with great care, to avoid invalidating associated data (profile, dominator tree, etc.). I'm worried that if you hide this behind a builder, it'll be more difficult to figure out where/how the CFG is modified (a simple grep for CFG-modifying functions won't do anymore).
Mostly what you see on the wiki. If I add a GIMPLE_COND, I want the builder to add the basic diamond for it (http://gcc.gnu.org/wiki/cxx-conversion/gimple-generation#Generating_statements_that_affect_control_flow)

I'd like to convert the profiling code, if you'd accept patches for that on the cxx-branch.
Absolutely!

Let's play with it a bit first on the CXX branch, and update documentation like doc/gimple.texi :-)
Sounds good. Though once stage 1 opens, I would prefer to move further implementation to trunk.


Diego.

Reply via email to