On 01/21/2013 03:09 PM, Dodji Seketeli wrote:
+ ith_elem_is_expansion |=
+ PACK_EXPANSION_P (TREE_VEC_ELT (ARGUMENT_PACK_ARGS (arg_pack),
+ index));
Let's use argument_pack_element_is_expansion_p here, too.
+ /* Do we need to use the PACK_EXPANSION_EXTRA_ARGS mechanism? */
+ bool use_pack_expansion_extra_args =
+ use_pack_expansion_extra_args_p (packs, len, unsubstituted_packs);
+
/* We cannot expand this expansion expression, because we don't have
all of the argument packs we need. */
- if (unsubstituted_packs)
+ if (use_pack_expansion_extra_args)
I think we don't need the variable anymore.
- /* We could not find any argument packs that work. */
- if (len < 0)
- return error_mark_node;
Let's replace this with an assert that len can't be <0.
OK with these changes.
Jason