Re: [PATCH] Multiversioning fixes (PR c++/55742)

[Jason Merrill]

On 01/18/2013 03:22 PM, Jakub Jelinek wrote:
    else if (TREE_CODE (args) != STRING_CST)
-    gcc_unreachable ();
+    {
+      error ("invalid %<target%> attribute value");
+      return false;
+    }

Maybe say that it needs to be a string?

We also need more tests, both for the example in the PR (and your 
introductory text) and for error cases.

Thanks,
Jason