On 8 January 2013 05:09, Hurugalawadi, Naveen
<naveen.hurugalaw...@caviumnetworks.com> wrote:
> Hi,
>
> AARCH64 back-end defines REVERSE_CONDITION but not REVERSIBLE_CC_MODE.
> REVERSE_CONDITION is used only in case REVERSIBLE_CC_MODE (mode) is
> nonzero.
>
> Please find attached the patch that defines REVERSIBLE_CC_MODE for
> aarch64 back-end. Please review the patch and let me know if there should be 
> any
> modifications?
>
> Build and tested on aarch64-thunder-elf (using Cavium's internal
> simulator).
>
> Thanks,
> Naveen.H.S
>
> 2013-01-08   Naveen H.S  <naveen.hurugalaw...@caviumnetworks.com>
>
>         * config/aarch64/aarch64.h (REVERSIBLE_CC_MODE): Define.


+/* A C expression whose value is one if it is always safe to reverse a
+   comparison whose mode is MODE.  If `SELECT_CC_MODE' can ever return
+   MODE for a floating-point inequality comparison, then
+   `REVERSIBLE_CC_MODE (MODE)' must be zero.
+   You need not define this macro if it would always returns zero or if the
+   floating-point format is anything other than `IEEE_FLOAT_FORMAT'.  */
+#define REVERSIBLE_CC_MODE(MODE) 1
+

Given the comment about SELECT_CC_MODE and the implementation of
aarch64_select_cc_mode this definition of REVERSIBLE_CC_MODE looks
broken to me.

/Marcus

Reply via email to