On Thu, Nov 29, 2012 at 10:34 AM, Andrew Pinski <pins...@gmail.com> wrote: > On Thu, Nov 29, 2012 at 10:30 AM, H.J. Lu <hongjiu...@intel.com> wrote: >> Hi, >> >> Since libsanitizer is used for bootstrap and compiled with raw_cxx, >> we need to use explicit -I for libstdc++-v3 header files in >> libsanitizer. Otherwise, we will get >> >> libtool: compile: unrecognized option `-D_GNU_SOURCE' >> libtool: compile: Try `libtool --help' for more information. >> >> This patch fixes it. OK to install? > > Is there a reason why your change to have libsanitizer be bootstrapped > wait to be committed until this patch was approved? > I think you should revert the change to have libsanitizer be > bootstrapped and only commit that after this patch has been approved > because right now nobody can do any work as bootstrap is broken. >
I posted my patch: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01530.html Since it didn't fix anything at the time, there was no incentive for anyone to review it. Please someone review my patch and get over with it. FWIW, libjava has the same issue with libstdc++ dependency as a bootstrap library. I applied the same solution to libsanitizer. -- H.J.
