Hi Richard, > This looks like it's working around a bug elsewhere. Originally, that fail is caused by function join_c_conditions(const char *cond1, const char *cond2) - if cond1 is "" and cond2 is NULL, then the function returns cond2, i.e. NULL. Attached patch fixes it - specifically, with it the function join_c_conditions prefers "" over NULL.
With this patch there is no need in the change in add_c_test, which
was proposed above, though maybe it's worth having it, as NULL strings
are not prohibited. If we decide to not change add_c_test, then we'd
probably need to remove similar check from function maybe_eval_c_test.
What do you think?
Changelog:
2012-11-28 Michael Zolotukhin <michael.v.zolotuk...@intel.com>
* gensupport.c (add_c_test): Check if expr isn't NULL.
* read-md.c (join_c_conditions): Prefer empty string over NULL.
--
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.
join_c_conditions.patch
Description: Binary data
