On Sat, Nov 24, 2012 at 5:47 PM, Doug Evans <d...@google.com> wrote: > > Hi. > This third patch passes options.results to GetSumFiles when fetching the > results > for the clean build. > It is useful in my use cases, but I'm not sure it's useful for upstream. > [An alternative is to add another option to specify the results file(s) > for the clean > build, but I'm being conservative and not adding an option if I don't have > to.] > > Ok to check in? > > 2012-11-24 Doug Evans <d...@google.com> > > * testsuite-management/validate_failures.py (CompareBuilds): Pass > options.results > to GetSumFiles for clean build.
I guess I don't understand your use case. CompareBuilds is for when you have a clean build that you want to crawl for failures to use as your comparison base. If you have a manifest already, why would you be using --clean_build? Diego.
