On Wed, Nov 21, 2012 at 12:23 PM, Andreas Schwab <sch...@linux-m68k.org> wrote: > Konstantin Serebryany <konstantin.s.serebry...@gmail.com> writes: > >> On Wed, Nov 21, 2012 at 2:50 AM, Andreas Schwab <sch...@linux-m68k.org> >> wrote: >>> David Miller <da...@davemloft.net> writes: >>> >>>> +// Are we using 32-bit or 64-bit syscalls? >>>> +// x32 (which defines __x86_64__) has __WORDSIZE == 32 >>>> +// but it still needs to use 64-bit syscalls. >>>> +#if defined(__x86_64__) || __WORDSIZE == 64 >>> >>> I don't think it is a good idea to use a glibc-internal macro. How >>> about __LP64__? >> >> __WORDSIZE is used throughout the library; > > That doesn't make it any better. > >> it is also redefined >> properly for the compilers which don't have it and may not have >> __LP64__ > > ??? __WORDSIZE is only defined by glibc. __LP64__ (or _LP64) is a > standard macro defined by the compiler.
libsanitizer is a third party library, its primary repository is not gcc. If we make such change (use __LP64__ instead of __WORDSIZE), we should make it upstream first. --kcc > > Andreas. > > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different."
