Thanks for all your work on this.

dnovi...@google.com (Diego Novillo) writes:
>       * config/mips/mips.c: Use new vec API in vec.h.

Looks good to me.  Just a couple of minor nits:

> @@ -4013,11 +4013,9 @@ struct mips_multi_member {
>  typedef struct mips_multi_member mips_multi_member;
> 
>  /* Vector definitions for the above.  */
> -DEF_VEC_O(mips_multi_member);
> -DEF_VEC_ALLOC_O(mips_multi_member, heap);

Please delete the comment too.

> @@ -4093,7 +4091,7 @@ mips_multi_copy_insn (unsigned int i)
>    struct mips_multi_member *member;
>  
>    member = mips_multi_add ();
> -  memcpy (member, &VEC_index (mips_multi_member, mips_multi_members, i),
> +  memcpy (member, &mips_multi_members[i],
>         sizeof (*member));
>    gcc_assert (!member->is_label_p);
>  }

This call now fits comfortably onto one line.

Doesn't need a retest, obviously. :-)

Richard

Reply via email to