On Tue, Nov 13, 2012 at 01:03:14PM -0800, Richard Henderson wrote:
> Note that your indentation is off in places.
>
> > + while ((start = strchr (end, '<')) && (end = strchr (end, '>')))
Above too when you mention it.
> Looking at all this, I'm wondering if we shouldn't split out all of this
> macro/include processing to a separate pass. Perform the preprocessing
> once, early, leaving the processed result in the build directory. Then
> run the original/traditional rtl reader on that when running the other
> rtl manipulation passes.
>
> The reason being that it's going to become increasingly hard to figure
> out if the reason for an error is in the macro processing or in the source
> md file. Being able to see the macro expansion is going to be important.
>
> Of course, another way to get this macro expansion is to leave the macro
> processing where it is and have another gen program that merely dumps the
> processed rtl. It wouldn't be run normally, but a makefile target used
> for debugging would be sufficient.
Yeah, one or other way to being able to debug what exactly has been
performed during the iterator expansion is certainly desirable for the
future.
> Which brings us to the question of what to do with the patch for 4.8.
> It's true that you made the deadline for stage1 closure. But there will
> be no users of this feature, so it begs the question of why we should
> apply it now. Have you a convincing reason?
>
> RM's do you have an opinion here?
I'm not against it going in now, it shouldn't be too risky and will
allow people to start experimenting with it sooner.
It is not the end of the world if it doesn't get applied now on the other
side, the gen*.c changes aren't that big and invasive and what would be much
harder to maintain longer term are the actual *.md file changes, which
aren't being submitted for 4.8.
Jakub
