On Tue, Nov 13, 2012 at 8:56 AM, Jakub Jelinek <[email protected]> wrote: > On Tue, Nov 13, 2012 at 08:46:55AM -0800, H.J. Lu wrote: >> On Tue, Nov 13, 2012 at 08:34:56AM -0800, H.J. Lu wrote: >> > This patch adds support for GCC multilib run-time libraries to >> > libsanitizer. I have to delete install-sh. Otherwise ac_aux_dir will >> > be wrong: >> > >> > ac_aux_dir= >> > for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do >> > for ac_t in install-sh install.sh shtool; do >> > if test -f "$ac_dir/$ac_t"; then >> > ac_aux_dir=$ac_dir >> > ac_install_sh="$ac_aux_dir/$ac_t -c" >> > break 2 >> > fi >> > >> > Tested with GCC autoconf/automake on Linux/x86-64. OK to install? >> > >> >> Here is a smaller patch without removing install-sh. Instead, it >> sets AC_CONFIG_AUX_DIR to "..". OK to install? > > I believe libsanitizer/install-sh wasn't imported from LLVM, and > if it is not needed in the GCC tree, it IMHO should be just removed. > Similarly libsanitizer/missing, maybe libsanitizer/depcomp (the former > one isn't present in any other lib*/ in gcc, the latter only in boehm-gc, > so I'd guess non-essential). Ditto ltmain.sh, config.sub, config.guess.
That is true. Those files aren't used in GCC tree. > libsanitizer/ChangeLog.asan should probably be just libsanitizer/ChangeLog. > > In any case, I'd prefer if configury maintainers could review that. Sure. Thanks. -- H.J.
