On Wed, Oct 31, 2012 at 9:16 AM, Eric Botcazou <ebotca...@adacore.com> wrote: >> Would it be OK with a pointer, but keeping the interface the same? >> That's certainly fine by me. > > Yes, a pointer would make things more legible here. > >> That's one of the things I'm not sure about after the C++ conversion: >> I've noticed some references creep in, but when should we use references >> and when pointers? I think Richard B made a comment about using references >> for things that can't be null. > > I'm personally dubious about using references, especially in the middle-end of > a file where all other functions use pointers; consistency should come first.
I agree. My comment was for isolated code parts that are being rewritten (I think it was the wide-int class). Consistency comes first. Thanks, Richard. > -- > Eric Botcazou
