Re: [PATCH] Fix libbacktrace on 32-bit sparc

[Ian Lance Taylor]

On Mon, Oct 29, 2012 at 11:15 AM, David Miller <da...@davemloft.net> wrote:
> From: Ian Lance Taylor <i...@google.com>
> Date: Mon, 29 Oct 2012 11:13:19 -0700
>
>> I changed it from vec->base + vec->size.  Now it is vec->base
>> + size, where size is the aligned version of vec->size.
>
> It is not.
>
> You don't modify 'size' at all.

Ah, yes, sorry.

Could you test this patch?

Ian

Index: mmap.c
===================================================================
--- mmap.c      (revision 192945)
+++ mmap.c      (working copy)
@@ -240,7 +240,8 @@ backtrace_vector_release (struct backtra
   aligned = (size + 7) & ~ (size_t) 7;
   alc -= aligned - size;

-  backtrace_free (state, (char *) vec->base + size, alc, error_callback, data);
+  backtrace_free (state, (char *) vec->base + aligned, alc,
+                 error_callback, data);
   vec->alc = 0;
   return 1;
 }