On Oct 26, 2012, Jakub Jelinek <ja...@redhat.com> wrote: > On Fri, Oct 26, 2012 at 04:30:41AM -0200, Alexandre Oliva wrote: >> From: Alexandre Oliva <lxol...@fsfla.org>
Fixed .git/config and the patches to use my @redhat.com address for these patches. >> +++ b/gcc/testsuite/gcc.dg/guality/pr54693.c > The #include <stdlib.h> looks useless to me, please remove it > and adjust gdb-test line accordingly. Thanks for catching this, it was a left-over from a failed experiment. > Don't we always ignore gimple_location on debug_stmts anyway? Right now, we mostly do, but they may become relevant once stmt frontier notes are implemented. >> + gimple def_temp = gimple_build_debug_bind (vexpr, comp, NULL); > Just wonder whether the above is sufficient It surely works. It may prevent common subexpression equivalences from being detected by VTA, but it also saves some temps. The exprs are of linear scaling, so they should be relatively small, but I can't guess whether there'd be any measurable benefit from splitting them up. Thanks for the reviews. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer
