On Thu, Oct 25, 2012 at 2:36 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote: > Ian Lance Taylor <i...@google.com> writes: > >> There is a decent change that this will break something on non-x86 >> systems. I will do what testing I am able to do after the commit. > > As expected, it did break the Solaris libgo build: > > * udpsock_posix.go lacked definitions of joinIPv4Group, joinIPv6Group, > setIPv6MulticastInterface, setIPv6MulticastLoopback. It turned out > that sockoptip_solaris.go isn't needed any longer, but > sockoptip_posix.go can be used instead. > > * Solaris lacked some stat_atim*.go in go/archive/tar initially. With > stat_atim.go used, it didn't build initially. Since Stat_t.[AC]tim > are Timestruc, we need a corresponding Unix(), now provided in > syscall_solaris.go. > > With those changes, libgo builds again, and Solaris/x86 testsuite > results are reasonable:
Thanks. I committed your patch to mainline. Ian
