Re: [lra] patch from Richard Sandiford's review of lra-assigns.c

[Vladimir Makarov]

On 12-10-12 11:00 AM, Richard Sandiford wrote:

Vladimir Makarov <vmaka...@redhat.com> writes:

    The following patch implements most Richard's proposals for LRA
lra-spills.c and lra-coalesce.c files.

    The patch was successfully bootstrapped on x86/x86-64.

    Committed as rev. 192389.

Thanks for the updates.  Looks good to me.  Just one comment though:

@@ -125,7 +136,7 @@ process_copy_to_form_thread (int regno1,
           last = regno_assign_info[last].next)
        regno_assign_info[last].first = regno1_first;
        regno_assign_info[last].next = regno_assign_info[regno1_first].next;
-      regno_assign_info[regno1_first].first = regno2_first;
+      regno_assign_info[regno1_first].next = regno2_first;
        regno_assign_info[regno1_first].freq
        += regno_assign_info[regno2_first].freq;
      }

I still think this is missing a:

        regno_assign_info[last].first = regno1_first;

Thanks, Richard.  I fixed in my today patch.