On Fri, Oct 12, 2012 at 1:17 PM, Janis Johnson <janis_john...@mentor.com> wrote:
> On 10/12/2012 08:05 AM, Joe Seymour wrote:
>> I'm observing vect/pr48765.c fail for non 64-bit PowerPC targets:
>>
>>> gcc/testsuite/gcc.dg/vect/pr48765.c:1:0: error: -m64 not supported in this
>> configuration
>>
>> This patch restricts the test to 64-bit PowerPC targets. I don't have commit
>> access, so if this OK perhaps someone could commit it for me?
>>
>> Thanks,
>>
>> 2012-10-12  Joe Seymour  <jseym...@codesourcery.com>
>>
>>       * gcc.dg/vect/pr48765.c: Restrict to 64-bit PowerPC targets.
>>
>> Index: gcc/testsuite/gcc.dg/vect/pr48765.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/vect/pr48765.c (revision 192402)
>> +++ gcc/testsuite/gcc.dg/vect/pr48765.c (working copy)
>> @@ -1,4 +1,4 @@
>> -/* { dg-do compile { target powerpc*-*-* } } */
>> +/* { dg-do compile { target powerpc64 } } */
>>  /* { dg-options "-m64 -O3 -mcpu=power6" } */
>>
>>  enum reg_class
>>
>
> No, the test should not add -m64, and -mcpu=power6 might conflict
> with multilib options.  I proposed a different fix for this test in
> <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01320.html> and then
> didn't follow up on it.
>
> I've copied Ira who added the test to see what she thinks of my
> proposed change, and David as the Power maintainer.

Janis,

Your patch seems reasonable to me.

Thanks, David

Reply via email to