On 10/08/2012 04:04 PM, Paolo Carlini wrote:
On 10/08/2012 03:57 PM, Jason Merrill wrote:
This is definitely an improvement, though for warnings about issues
with the left or right argument, we could use the EXPR_LOCATION of
the problematic argument rather than the location of the new operand.
I agree. Let me see if I can figure out something straightforward enough.
So, there is a serious difficulty, I'm afraid: for the example at issue,
EXPR_LOCATION (arg_left) is 0 not any meaningful value. And of course
EXPR_LOC_OR_HERE would not be better in this case, would give
input_location. So, what do you think? Shall we just go with the loc for
now, or you think there is something relatively safe we can try?
Thanks,
Paolo.
