On Thu, Jul 2, 2026 at 11:12 AM Andi Kleen <[email protected]> wrote:
>
> On Thu, Jul 02, 2026 at 10:57:53AM -0700, Ian Lance Taylor wrote:
> > On Wed, Jul 1, 2026 at 11:24 PM Andi Kleen <[email protected]> wrote:
> > >
> > > From: Andi Kleen <[email protected]>
> > >
> > > Reworked patch based on a more compatible interface from Ian Lance
> > > Taylor.
> > >
> > > This allows tools to access discriminator and decl_line to resolve
> > > inline stacks for autofdo.
> >
> > Thanks. I'm still thinking about decl_line. It's not a value
> > associated with a specific PC. It feels a bit weird to return it
> > attached to a PC. On the other hand it's admittedly less efficient to
> > require the caller to look up the function name to get the decl_line
> > (in libbacktrace this would be backtrace_syminfo to get the initial PC
> > and backtrace_pcinfo to get the line number of that PC; this could of
> > course be cached).
>
> Would that work with inlines?  autofdo needs it for the full inline
> stack.

It should work with inlined code. At least, I can't think of a reason
why it wouldn't.

Ian

Reply via email to