Hi Alexandre,

> I'm not sure this was pending review.

thay'd been only the cover message including the merged -1/6 to 6/6 patches.

> On May  6, 2026, Rainer Orth <[email protected]> wrote:
>
>> I'm also including the full patch series in case someone wants to try
>> it.
>
> It looks good to me.
>
> I'm not sure why we're making some settings unconditional, such as:
>
>> @@ -2382,14 +2325,8 @@ ia64*-*-elf*)
>>      tm_file="${tm_file} elfos.h newlib-stdint.h ia64/sysv4.h ia64/elf.h"
>>      tmake_file="ia64/t-ia64"
>>      target_cpu_default="0"
>> -    if test x$gas = xyes
>> -    then
>> -            target_cpu_default="${target_cpu_default}|MASK_GNU_AS"
>> -    fi
>> -    if test x$gnu_ld = xyes
>> -    then
>> -            target_cpu_default="${target_cpu_default}|MASK_GNU_LD"
>> -    fi
>> +    target_cpu_default="${target_cpu_default}|MASK_GNU_AS"
>> +    target_cpu_default="${target_cpu_default}|MASK_GNU_LD"
>>      ;;
>>  ia64*-*-freebsd*)
>>      tm_file="${tm_file} elfos.h ${fbsd_tm_file} ia64/sysv4.h ia64/freebsd.h"
>> @@ -2429,10 +2366,7 @@ ia64-hp-*vms*)
>>      tm_file="${tm_file} elfos.h ia64/sysv4.h vms/vms.h ia64/vms.h"
>>      tmake_file="${tmake_file} ia64/t-ia64"
>>      target_cpu_default="0"
>> -    if test x$gas = xyes
>> -    then
>> -            target_cpu_default="${target_cpu_default}|MASK_GNU_AS"
>> -    fi
>> +    target_cpu_default="${target_cpu_default}|MASK_GNU_AS"
>>      extra_options="${extra_options} ia64/vms.opt"
>>      ;;
>>  iq2000*-*-elf*)
>
> but IIRC there was discussion about some such changes back then, so...

There was: ia64*-*-elf* is gas/gld-only, so no need for the check.

Likewise, ia64-hp-*vms* is gas-only, too, AFAICT, although I never
received any review on the VMS parts at all to the point that I stopped
caring about those.  Just in case, I suggested ways to deal with the
non-trivial issues if need be, but didn't incorporate those since I know
of no way at all to test them.  However, Eric mentioned that AdaCore had
stopped doing VMS builds years ago which suggests the VMS targets are
dead.

> If this is still pending, Ok, thanks ;-)

Great, thanks.  I'd also like to thank everyone involved in both testing
and review of this series for their help getting this right and their
patience.  It's been a total maze of revisions and reworks of patches,
but I believe the end result is way better than what I had initially.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to