The "c++" in the Subject line should be outside the [] brackets so that
it's retained by 'git am'. In general what's after the [] should be the
commit subject line. git format-patch or git send-email can help
simplify this process.
On 6/29/26 7:49 AM, Georg-Johann Lay wrote:
mangle.cc::mangle_ctor_vtbl_for_type has the following comment:
We use the production
<special-name> ::= CT <type> ...
but the code does:
write_string ("_Z");
write_string ("TC");
so the comment should obviously read
<special-name> ::= TC <type> ...
Below is an according patch to apply to trunk.
Johann
The intro that isn't part of the commit message doesn't need to
duplicate the commit message.
--
The line between intro and commit message should include "scissors", e.g.
-- 8< --
so 'git am' prunes the intro.
c++: Fix production comment for mangle_ctor_vtbl_for_type.
and then the commit subject line doesn't need to be repeated in the
commit message body, 'git am' will use the email subject line (after
removing the initial [] section).
mangle.cc::mangle_ctor_vtbl_for_type has
write_string ("_Z");
write_string ("TC");
and hence the function comment should read
We use the production
<special-name> ::= TC <type> ...
instead of the current
<special-name> ::= CT <type> ...
gcc/cp/
* mangle.cc (mangle_ctor_vtbl_for_type): Fix production in
comment.
And the ChangeLog entry should start with a tab.
Pushed with those adjustments, thanks.
Jason
