On Thu, Jun 11, 2026 at 04:06:29AM -0500, Manjunath S Matti wrote:
> The changes have been bootstrapped and regression tested on
> powerpc64le-linux.
> 
> Changes from V3:
> * Corrected the tab width to 8 chars in Changelog instead of spaces.
> * 2 Space indentation between date and name.
> * Fixed the typo "PowerPC" and prototypes missing the ";" in texi file.

This look ok, with one minor change in the ChangeLog, that you can do
without doing another patch review.

In particular:

> 2026-05-13  Manjunath Matti  <[email protected]>
> 
> gcc/ChangeLog:
>       * config/rs6000/predicates.md (const_0_to_6_operand): New predicate.
>       * config/rs6000/rs6000-builtins.def (__builtin_vsx_xxmulmul): Add new

        ...

>       (<vsx_xxmulmul>): New define_insn.
>       (<vsx_xxmulmulhiadd>): Likewise.
>       (<vsx_xxmulmulloadd>): Likewise.
>       (<vsx_xxssumudm>): Likewise.
>       (<vsx_xxssumudmc>): Likewise.
>       (<vsx_xxssumudmcext>): Likewise.
>       (<vsx_xsaddadduqm>): Likewise.
>       (<vsx_xsaddaddsuqm>): Likewise.
>       (<vsx_xsaddsubuqm>): Likewise.
>       (<vsx_xsaddsubsuqm>): Likewise.
>       (<vsx_xsmerge2t1uqm>): Likewise.
>       (<vsx_xsmerge2t2uqm>): Likewise.
>       (<vsx_xsmerge2t3uqm>): Likewise.
>       (<vsx_xsmerge3t1uqm>): Likewise.
>       (<vsx_xsrebase2t1uqm>): Likewise.
>       (<vsx_xsrebase2t2uqm>): Likewise.
>       (<vsx_xsrebase2t3uqm>): Likewise.
>       (<vsx_xsrebase2t4uqm>): Likewise.
>       (<vsx_xsrebase3t1uqm>): Likewise.
>       (<vsx_xsrebase3t2uqm>): Likewise.
>       (<vsx_xsrebase3t3uqm>): Likewise.

Please remove the <> brackets, i.e. the above should be:

>       (vsx_xxmulmul): New define_insn.
>       (vsx_xxmulmulhiadd): Likewise.
>       (vsx_xxmulmulloadd): Likewise.
>       (vsx_xxssumudm): Likewise.
>       (vsx_xxssumudmc): Likewise.
>       (vsx_xxssumudmcext): Likewise.
>       (vsx_xsaddadduqm): Likewise.
>       (vsx_xsaddaddsuqm): Likewise.
>       (vsx_xsaddsubuqm): Likewise.
>       (vsx_xsaddsubsuqm): Likewise.
>       (vsx_xsmerge2t1uqm): Likewise.
>       (vsx_xsmerge2t2uqm): Likewise.
>       (vsx_xsmerge2t3uqm): Likewise.
>       (vsx_xsmerge3t1uqm): Likewise.
>       (vsx_xsrebase2t1uqm): Likewise.
>       (vsx_xsrebase2t2uqm): Likewise.
>       (vsx_xsrebase2t3uqm): Likewise.
>       (vsx_xsrebase2t4uqm): Likewise.
>       (vsx_xsrebase3t1uqm): Likewise.
>       (vsx_xsrebase3t2uqm): Likewise.
>       (vsx_xsrebase3t3uqm): Likewise.

-- 
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: [email protected]

Reply via email to