Re: [PATCH 3/4] openmp: Add barrier kind to GOMP_barrier and GOMP_barrier_cancel

[Tobias Burnus]

Paul-Antoine Arras wrote:
--- a/libgomp/barrier.c
+++ b/libgomp/barrier.c
@@ -29,7 +29,7 @@
  
  
  void
-GOMP_barrier (void)
+GOMP_barrier (int kind)
  {
    struct gomp_thread *thr = gomp_thread ();
    struct gomp_team *team = thr->ts.team;
@@ -42,7 +42,7 @@ GOMP_barrier (void)
  }
  
  bool
-GOMP_barrier_cancel (void)
+GOMP_barrier_cancel (int kind)
  {
    struct gomp_thread *thr = gomp_thread ();
    struct gomp_team *team = thr->ts.team;

This will break backward compatibility. I think you need to find a 
function new name + entry in .map

And maybe update 
https://gcc.gnu.org/onlinedocs/libgomp/Implementing-BARRIER-construct.html 
would be nice as well.

Don't you need something like '(void) kind;' or __attribute__ ((unused)) 
or similar to silence unused-parameter warning? Or don't we have those 
warnings?

Tobias