Hi gcc-patches mailing list,
Ben Boeckel via Sourceware Forge 
<[email protected]> has requested that the 
following forgejo pull request
be published on the mailing list.

Created on: 2026-01-19 01:30:08+00:00
Latest update: 2026-06-09 16:22:24+00:00
Changes: 3 changed files, 8 additions, 7 deletions
Head revision: ben.boeckel/gcc-TEST ref p1689-doc-updates commit 
98cf915ac28f642bbe3cc265f65bd8733a618caa
Base revision: gcc/gcc-TEST ref trunk commit 
8d1a6a84b158a6d825fb3d2dcbba8e02cce990fe r16-6888-g8d1a6a84b158a6
Merge base: 7dda46111eb3ebc390c0287a00d97a69567b33f1
Full diff url: https://forge.sourceware.org/gcc/gcc-TEST/pulls/134.diff
Discussion:  https://forge.sourceware.org/gcc/gcc-TEST/pulls/134
Requested Reviewers:

Here are some minor fixes to documentation, formatting, and styling to the 
P1689R5 support through the `-fdeps-*` flags.

---
## Changes since v3

- Reverted `-fdeps-format=p1689r5` flag description. This pattern conflicts 
with future format name additions AFAICT.
- Rebased onto `master`

## Changes since v2

- Rebased for a conflict resolution.
- Submitted via Forge integration.

## Changes since v1

- Rebased and dropped the first patch (since fixed by a tree-wide change)

---
Also submitted to gcc-patches (last full send in Oct 2025). Pinged in Jan 2026 
with an updated patch with conflict resolutions.

https://gcc.gnu.org/pipermail/gcc-patches/2025-October/696793.html

This is v3 with those conflict resolutions in place.


Changed files:
- M: gcc/c-family/c.opt
- M: libcpp/init.cc
- M: libcpp/mkdeps.cc


Ben Boeckel (3):
  libcpp/mkdeps: fix indentation
  libcpp/init: remove unnecessary `struct` keyword
  gcc/c-family/c.opt: clarify `-fdeps-*` flag documentation

 gcc/c-family/c.opt |  6 +++---
 libcpp/init.cc     |  2 +-
 libcpp/mkdeps.cc   | 11 ++++++-----
 3 files changed, 10 insertions(+), 9 deletions(-)

Range-diff against v1:
1:  0a6312d913e5 = 1:  1a3def2e4051 libcpp/mkdeps: fix indentation
2:  4d10bc2a356a = 2:  6e95b50cdf3d libcpp/init: remove unnecessary `struct` 
keyword
3:  3cefb58b97e7 ! 3:  98cf915ac28f gcc/c-family/c.opt: clarify `-fdeps-*` flag 
documentation
    @@ Metadata
      ## Commit message ##
         gcc/c-family/c.opt: clarify `-fdeps-*` flag documentation
     
    -    Reword to clarify that the `-fdeps-file=` file will be written to.
    +    Move the only supported value (as of today) to the flag name itself.
    +    Also reword to clarify that the `-fdeps-file=` file will be written to.
     
         Fixes: 024f135a1e9 (p1689r5: initial support, 2023-09-01)
     
    @@ Commit message
                 * c.opt: Clarify `-fdeps-*` documentation.
     
      ## gcc/c-family/c.opt ##
    -@@ gcc/c-family/c.opt: Structured format for output dependency 
information.  Supported (\"p1689r5\").
    +@@ gcc/c-family/c.opt: MT
    + C ObjC C++ ObjC++ Joined Separate MissingArgError(missing makefile target 
after %qs)
    + -MT <target>      Add a target that does not require quoting.
    + 
    +-fdeps-format=
    ++fdeps-format=p1689r5
    + C ObjC C++ ObjC++ RejectNegative Joined MissingArgError(missing format 
after %qs)
    +-Structured format for output dependency information.  Supported 
(\"p1689r5\").
    ++Structured format for output dependency information.
      
      fdeps-file=
      C ObjC C++ ObjC++ RejectNegative Joined MissingArgError(missing output 
path after %qs)
-- 
2.54.0

Reply via email to