Hi Pietro,

> On 8 Jun 2026, at 19:43, Pietro Monteiro <[email protected]> wrote:
> 
> On Mon, Jun 8, 2026, at 1:14 PM, Iain Sandoe wrote:
>>> On 8 Jun 2026, at 17:59, Jeffrey Law <[email protected]> wrote:
>>> On 6/8/2026 7:26 AM, Iain Sandoe wrote:
>>>> 
>>>>> On 8 Jun 2026, at 14:02, Pietro Monteiro <[email protected]> 
>>>>> wrote:
>>>>> 
>>>>> The Algol 68 frontend adds a section with information on exported
>>>>> modes and procedures to libraries and object files.  Instead of
>>>>> erroring out when encountering a Mach-O library keep reading it so the
>>>>> frontend can find the exports section.
>>>>> 
>>>>> libiberty/ChangeLog:
>>>>> 
>>>>> * simple-object-mach-o.c (MACH_O_MH_DYLIB): New definition.
>>>>> (simple_object_mach_o_match):
>>>> OK from a Darwin PoV (but I’m not sure if I can OK libiberty changes).
>>> Given it's mach-o, it seems like you're likely in the best position to 
>>> review.  So, yea I think you ought to be able to OK libiberty changes.
>> 
>> @ Jeff : thanks.
>> 
>> @pietro, I don’t think you have mentioned how this has been tested.
> 
> Sorry, I only had a small note in the original email. I tested this
> patch and the A68 frontend ones together on x86_64 darwin.  Before, the
> FE would always fail to compile anything in darwin. After applying the
> patch so it searches for export sections on .dylib files and this
> libiberty one, the FE sucessfully finds libga68.dylib and its export
> section.  The full testsuite for Algol 68 is now passing on x86_64
> darwin.

OK .. after some off-list discussion, I now understand the conditions under
which there’s a fail which this series fixes.

>> Assuming a positive test-result, the patch is OK.
> 
> Thanks! Assuming a positive test result in the GCC-16 branch may I
> backport this patch to it too? The ga68 breakage on darwin is on GCC 16
> too.


OK, but please let the patch set bake on trunk for a week first.

thanks for the patches,
Iain

Reply via email to