Sandra wrote in the v6 00/11 patch:
[…] I wasn't happy with it: the data
structure describes a single iterator, so using the plural
"OMP_ITERATORS_*" prefix was highly confusing. I also added some
constructors and tweaked copy_omp_iterator to hide the magic
numbers for the size of the underlying vector.
Thanks for the additional cleanup – that way it is even a larger
improvement!
Sandra Loosemore wrote:
gcc/c/ […]
gcc/cp/ […]
gcc/fortran/ […]
gcc/
[…]
* tree.h (OMP_ITERATOR_VAR, OMP_ITERATOR_BEGIN, OMP_ITERATOR_END,
OMP_ITERATOR_STEP, OMP_ITERATOR_ORIG_STEP, OMP_ITERATOR_BLOCK,
OMP_ITERATOR_LABEL, OMP_ITERATOR_INDEX, OMP_ITERATOR_ELEMS,
OMP_ITERATOR_COUNT, OMP_ITERATOR_EXPANDED_P): New macros.
(make_omp_iterator, make_expanded_omp_iterator): New constructor
functions.
LGTM. — I hope we haven't missed any iterator accesses in this cleanup!
Tobias
PS: i still need to
