On Wed, May 27, 2026 at 6:41 AM Iain Sandoe <[email protected]> wrote: > > > > > On 26 May 2026, at 22:35, H.J. Lu <[email protected]> wrote: > > > > On Tue, May 26, 2026 at 11:19 PM Iain Sandoe <[email protected]> > > wrote: > >> > >> HJ, > >> > >> Bootstrap on 32b Darwin (and 64b Darwin with 32b multilib) is still broken > >> after > >> more than three weeks, > >> > >> It is reasonable to have a temporary break if there is a trivial typo or > >> other fix > >> that can be applied in a timely manner. > >> > >> However, in this case, it seems your initial design needed some amendment, > >> and that means a more complex fix is needed - which needs additional > >> review. > >> > >> Today I now faced two concurrent bootstrap breaks on some platform versions > >> - this is just consuming time in a non-constructive manner. > > > > It only shows that maintainers pay no attention to Darwin. In the meantime, > > you can submit a very simple libssp patch to fix Darwin build by changing > > __stack_chk_guard to unsigned long for Darwin. > > I find this unbelievable, and cannot think of any other maintainer who would > leave a regulalry-tested platform broken for weeks, and then try pass the > blame > to reviewers for not being quick enough review band aid upon band aid. > > The responsibility for producing good reviewed patches lies with you - not > with other maintainers for platforms you break with bad patches, and not with > reviewers who might have more pressing things to address.
I submitted a fix and suggested one line change to address Darwin build. You choose to ignore my suggestion. > I would be very disappointed if this is what is considered to be “good > community” behaviour. > > Iain > ** even with all your patches applied the testcases need work - it is not at > all > helpful that you leave it to others to finish off your incomplete work. > I submitted patches to address regressions. Some newly added tests failed due to the existing libssp implementation bug. You can xfail them if ssp isn't provided in libc. -- H.J.
