On Sep 25, 2012, Jakub Jelinek <ja...@redhat.com> wrote: > (the other alternative would be to use mode in the hash function etc., > but if usually the same pseudo has the same mode everywhere, then the above > should be good enough).
AFAIK each pseudo is referenced everywhere using the same RTX; if so, it follows that it has the same mode in all uses. > I believe the coding conventions ask to put the inlines outside of the > class body, see e.g. coverage.c. I wasn't sure about one-liners; hash-table.h itself has inline one-liners, one of which I used as the basis for the descriptor. That said, the braces were not in separate lines. I'm going on a trip tomorrow morning, and I'll only return on Friday evening. I'll have a look at the C++ coding conventions and the other issues you brought up when I return. However, if you'd rather have the fix in before that, I won't mind if you pick it up from where I left. > BTW, the patch fixes most of the (non-LTO) fails left in the > http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00711.html patch, good job! Cool! Thanks for the good news, and for the review. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer
