On Tue, Sep 25, 2012 at 12:44 AM, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > The current patterns will never match. Fix that. Also, merge the > SI and DI variants of each. Also, remove an unnecessary earlyclobber. > And add a pattern for what combine considers the canonical form of > one of these patterns. > > Bootstrapped and regression checked on powerpc64-linux. Also tested > all these patterns manually, -m32 and -m64 and -m32 -mpowerpc64, > -misel and -mno-isel. > > Okay to apply? > > > Segher > > > 2012-09-24 Segher Boessenkool <seg...@kernel.crashing.org> > > gcc/ > PR target/51274 > * config/rs6000/rs6000.md (ne0si): Remove unnecessary > earlyclobber. Merge with... > (ne0di): ... to... > (ne0_<mode>): New. > (plus_ne0si): Merge with... > (plus_ne0di): ... to... > (plus_ne0_<mode>): New. > (compare_plus_ne0si): Merge with... > (compare_plus_ne0di)... to... > (compare_plus_ne0_<mode>): New. > (compare_plus_ne0_<mode>_1): New. > (plus_ne0si_compare): Merge with... > (plus_ne0di_compare)... to... > (plus_ne0_<mode>_compare): New.
This is okay, but can you also add a target testcase to check that the correct assembly instructions are generated so that we can try to ensure this does not regress again? Thanks, David
