[Adding back <[email protected]>.]

Hi!

On 2026-03-23T11:46:31-0400, Stefan Weigl-Bosker <[email protected]> wrote:
>> (I suppose) your "User-Agent: Mozilla Thunderbird" has mangled [...]
>
> Sorry about that, the email I have configured for git was getting 
> blocked by spam filter so I tried sending manually from another email. 
> Talked to overseers and got it whitelisted so things should be fine now.

Ah, I see.  Good.


>> All that said, which GCC sources have you been looking at?  As far as I
>> can tell, these typos (and more) have already been fixed in 2024-01-04
>> commit r14-6907-gab80d838d5e0e039c7ff4d8eec20819d8a820797
>> "OpenMP: trivial cleanups to omp-general.cc"?
>
> When I look at master, releases/gcc-14, etc, the typo still seems to be 
> present.
>
> eg: https://gcc.gnu.org/cgit/gcc/tree/gcc/omp-general.h

Oh wow, my bad: you're talking about/fixing up 'gcc/omp-general.h' -- I
was looking at 'gcc/omp-general.cc' (which Sandra had fixed up, but not
the other).

One last thing (for your next submission):

    $ contrib/gcc-changelog/git_check_commit.py --print-changelog 
    Checking b789ffb459d663cd6ad6df96f3a6c7d80acdbb7c: FAILED
    ERR: line should start with a tab: "    * omp-general.h: Fix typos."

With that fixed up, I've pushed to trunk
commit f7cf25774c9f3730248ca36b60ed7e06e7649b7c
'gcc: Fix "uselful" and "directivers" typos in comment', see attached.


Grüße
 Thomas


>From f7cf25774c9f3730248ca36b60ed7e06e7649b7c Mon Sep 17 00:00:00 2001
From: Stefan Weigl-Bosker <[email protected]>
Date: Wed, 4 Mar 2026 18:51:51 -0500
Subject: [PATCH] gcc: Fix "uselful" and "directivers" typos in comment

gcc/ChangeLog:

	* omp-general.h: Fix typos.
---
 gcc/omp-general.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/omp-general.h b/gcc/omp-general.h
index a3f6062cdeb..4a6d58471de 100644
--- a/gcc/omp-general.h
+++ b/gcc/omp-general.h
@@ -1,5 +1,5 @@
-/* General types and functions that are uselful for processing of OpenMP,
-   OpenACC and similar directivers at various stages of compilation.
+/* General types and functions that are useful for processing of OpenMP,
+   OpenACC and similar directives at various stages of compilation.
 
    Copyright (C) 2005-2026 Free Software Foundation, Inc.
 
-- 
2.34.1

Reply via email to