On 09/03/26 00:02, Andi Kleen wrote:
External email: Use caution opening links or attachments
On 2026-03-08 10:23, Jan Hubicka wrote:
From: Dhruv Chawla <[email protected]>
This works around a bug I was seeing while testing
autoprofiledbootstrap
where it appeared that perf record was only recording the make
invocation and not any of the child processes. I did not find any
configuration that would make it do so, so forcing the flag in
gcc-auto-profile will make sure that it doesn't happen regardless of
perf's settings.
Bootstrapped and regtested on aarch64-linux-gnu.
Signed-off-by: Dhruv Chawla <[email protected]>
gcc/ChangeLog:
PR gcov-profile/123923
* config/aarch64/gcc-auto-profile: Add --inherit to perf record
flags.
* config/i386/gcc-auto-profile: Likewise.
In the PR discussion it was not clear why --inherit is needed on your
setup. It seems to be on by default on my setup.
I suppose it does not hurt to set it explicitely especially if the
default canbe overwritten in .perfconfig.
I would like Andi to comment, since he is original author of the patch.
If he is fine with it, the change is OK.
I suppose it must be something SPE specific. In the past
some special perf profiling modes disabled inherit, maybe that's the
case
for SPE too.
I doubt it's needed for x86 (but won't hurt either)
Actually, I hit this issue on x86 as well! I think it has something to do
with how the machines I use are configured, though I could not find any
perf-specific config that was related to this.
But I guess the patch is ok.
-Andi
--
Regards,
Dhruv
