On 2026-02-06 12:21, Richard Earnshaw (foss) wrote:
On 06/02/2026 10:11, Torbjorn SVENSSON wrote:
On 2026-01-27 11:03, Richard Earnshaw wrote:
On 27/01/2026 06:17, Alexandre Oliva wrote:
On Jan 23, 2026, "Richard Earnshaw (foss)" <[email protected]> wrote:
On 19/01/2026 19:23, Alexandre Oliva wrote:
-/* { dg-additional-options "-march=armv7-a -mthumb" { target { arm_arch_v7a_ok
&& arm_thumb2_ok } } } */
+/* { dg-additional-options "-mcpu=unset -march=armv7-a -mthumb" { target {
arm_arch_v7a_ok && arm_thumb2_ok } } } */
This will fail if other options set, or config settings imply,
-mfloat-abi=hard and -mfpu=auto.
So we should use -march=armv7-a+fp
Oh, good catch, thanks.
Here's the patch with this fix, currently under retesting.
I'll take your response above as approval with changes.
Reset the cpu selection to the default on tests that set -march
explicitly instead of using dg-add-options. The latter would reset
the cpu selection to avoid interference from TOOL_OPTIONS.
Also add +fp to -march in tests that don't override float-abi and fpu,
so that -mfloat-abi=hard -mfpu=auto in TOOL_OPTIONS won't cause a
failure.
for gcc/testsuite/ChangeLog
* gcc.target/arm/bfloat16_simd_1_2.c: Add -mcpu=unset.
* gcc.target/arm/bfloat16_simd_2_2.c: Likewise.
* gcc.target/arm/bfloat16_simd_3_2.c: Likewise.
* gcc.dg/torture/pr120347.c: Likewise. Add +fp to -march.
This is OK, thanks.
Can this patch be picked for release/gcc-15 too?
Yes, as long as you've tested it properly.
Pushed as r15-10836-ge1bb34116fa829.
Kind regards,
Torbjörn
R.
