On Thu, Sep 13, 2012 at 12:10 AM, Oleg Endo <oleg.e...@t-online.de> wrote: > Hello, > > On Sun, 2012-09-02 at 01:19 +0200, Oleg Endo wrote: >> On Sat, 2012-09-01 at 18:25 +0200, Oleg Endo wrote: >> > On Sat, 2012-09-01 at 16:17 +0000, Joseph S. Myers wrote: >> > > On Sat, 1 Sep 2012, Oleg Endo wrote: >> > > >> > > > Ping! >> > > > >> > > > This allows one to include e.g. <algorithm> in GCC source files. >> > > > Since the switch to C++ has been made, this should be OK to do now, I >> > > > guess. >> > > >> > > This is not a review, but have you tested building the Ada front end with >> > > this patch applied? Given recent issues relating to how Ada uses >> > > system.h, I think any such changes need testing for Ada. >> > > >> > >> > No I haven't. C and C++ only. Good to know, thanks. Will try. >> > >> >> OK, now I have. ada, c, c++, fortran, go, java, objc, obj-c++ do build >> here. >> > > Would it be OK to install the patch originally posted here: > http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01761.html ? > > If not OK, it's also fine. Just let me know. It seems the issue can be > worked around in individual source files by including <cstdlib> before > "system.h" (as it is already done in config/sh/sh.c).
In general system headers should be exclusively included from system.h. As C++ standard headers may pull in system headers that includes them. This is to allow various workarounds for host compiler / OS issues in a central place as well as not affecting those headers with the #poisonings we do at the end of system.h. Richard. > Cheers, > Oleg > > >
