Actually, the edge is fairly simple. I have BB5 (BB_COLD_PARTITION) -> BB10 (BB_HOT_PARTITION) -> EXIT
and BB10 has no other incoming edges. and we are duplicating it. My hypothesis, is that with a gcov based profile, we should never have such partitioning on the edges, BB10 should be COLD as well. My suggestion was to avoid shrink-wrapping failing on the block duplication for this case, but that would hide the real cause. I now prefer to understand why BB10 is HOT in the first place... if this is a correct assumption that it should not be. Thanks Christian On 09/11/2012 02:46 PM, Steven Bosscher wrote: >> Does this restriction look right to you ? (regression tests are still >> running on x86 and sh) > > Please generate your patches with diff -up (or svn diff -x -up). > >> + && (BB_PARTITION (e->src) == BB_PARTITION (e->dest)) > > No need for parentheses around this check. > > The shrink wrapping code appears to be dealing with partitioning, or > at least there are BB_COPY_PARTITIONs further down. So I can't tell > whether this fix is correct. Can you show in more detail what happens? > (A dotty graph is always helpful ;-) > > Ciao! > Steven >
