On Mon, 19 Jan 2026, Tobias Burnus wrote:
> I intent to commit it tomorrow, but fixes can be be also applied after I 
> committed :-)

Totally. :-)

And, for the record, I am impressed about you diligent bookkeeping and 
documenting all these changes.

On Tue, 20 Jan 2026, Tobias Burnus wrote:
> Thanks Sandra for the suggestions. I have now committed the attached patch.

+  <li>The <a 
href="https://gcc.gnu.org/onlinedocs/libgomp/Memory-allocation.html";>
+      memory allocation</a> support has been enhanced: 

Personally I'd omit the leading "The", alas that's just my intuition and 
Sandra surely will know for sure. 

+      for allocators with the
+      <code>pinned</code> trait, including 
<code>ompx_gnu_pinned_mem_alloc</code>,
+      the <a href="https://gcc.gnu.org/onlinedocs/libgomp/nvptx.html";>CUDA
+      API (if available)</a> is used

Do you intentionally have "(if available)" as part of the link text here?

How about "<a href="...">CUDA API</a> is used (if available)."?

+      ... Nvidia GPUs ...

As much as I dislike it, isn't it NVIDIA, all uppercase?

+  <li>OpenMP 5.0: Limited support for <code>declare mapper</code> has been 
added
+      for C and C++, only. 
                   ^^^ 
This comma strikes me as odd. You could drop it, or also drop "only" which 
is implied in such a case?

+  <li>For OpenMP directives and clauses that have been deprecated in OpenMP 
5.0,
+      5.1, or 5.2, a deprecation warning is shown, hinting at the to-be-used
+      syntax; the warning is on by default and can be silenced using
+      <code>-Wno-deprecated-openmp</code>. 

Let's make "The warning..." a full sentence, i.e., full stop instead of 
semicolon before.

+      Additionally, a deprecation warning is
+      shown when using a deprecated named constant or API routine; this warning
+      can be silenced using <code>-Wno-deprecated-declarations</code>.

Probably similarly here.

+      
<code>define_static_</code>{<code>string</code>,<code>object</code>,<code>array</code>}

Space after these two commas, unless I am missing something.

Gerald

Reply via email to