Hi HNO3:

Could you add a signoff message to git message by GCC's DCO policy.

https://gcc.gnu.org/dco.html

> @@ -4168,7 +4176,7 @@ riscv_rtx_costs (rtx x, machine_mode mode, int 
> outer_code, int opno ATTRIBUTE_UN
>               /* We still need two instruction for move with ZILSD,
>                  but let minus one cost to let subreg split don't.
>                  TODO: Add riscv_tune_param for this.  */
> -             *total = COSTS_N_INSNS (2) - 1;
> +             *total = 0;
>               return true;
>             }
>
> @@ -4177,7 +4185,7 @@ riscv_rtx_costs (rtx x, machine_mode mode, int 
> outer_code, int opno ATTRIBUTE_UN
>               && riscv_2x_xlen_mode_p (mode))
>             {
>               /* TODO: Add riscv_tune_param for this.  */
> -             *total = COSTS_N_INSNS (1);
> +             *total = 0;
>               return true;
>             }
>
> @@ -4190,7 +4198,7 @@ riscv_rtx_costs (rtx x, machine_mode mode, int 
> outer_code, int opno ATTRIBUTE_UN
>           && riscv_2x_xlen_mode_p (mode))
>         {
>           /* TODO: Add riscv_tune_param for this.  */
> -         *total = COSTS_N_INSNS (1);
> +         *total = 0;
>           return true;
>         }

^^^^ For the above 3 cost changes, I am not really happy to see this
set to 0 since it  kinda says they are free, so don't set it to zero
unless we have very good justification, and need to add a comment if
so.

Reply via email to