Richard Biener <[email protected]> writes:

> ISTR the functions used so further down we can select an appropriate other
> built in which name depends on the type.  If this isn’t done here there’s no
> reason to use this function at all.  If it is, then using the lhs type is
> wrong.  What about simply failing if the function returns NULL?

The effect of the patch as-is is effectively that; in cases when the
IFNs for sin and cos are used, they're applied to vector types, which
mathfn_built_in will return null for.

I initially considered just skipping calls to IFNs entirely, because
inevitably mathfn_built_in will fail on types those are used for, but I
didn't want to bake that assumption in too deeply.
-- 
Arsen Arsenović

Attachment: signature.asc
Description: PGP signature

Reply via email to