On 11/27/25 11:10 AM, Dimitar Dimitrov wrote:
So the comment for the function says we want to order with the highest
execution frequency first, this patch would seem to do the opposite.
Similarly at the call site from within reorder_basic_blocks_simple, the
expectation is the most desirable (highest priority?) edges should be first.
At the least I think updates to the comments are advisable. Explaining why
descending order is preferred seems highly advisable too.
jeff
Hi Jeff,
I consider "descending order" and "highest execution frequency first" to
be identical statements.
But I think the underlying question is why. Descending order would
imply to me lowest frequency first. Clearly there's something basic I'm
missing here.
I'll rephrase the comment and I'll send a new version to hopefully make
it more clear.
Thanks. And just to be clear, I think the issue at had is really just
making sure the comments are clear about intent and the code/comments
are consistent with each other.
Jeff
