On Wed, 2025-11-12 at 22:16 +0100, Evgeny Karpov wrote:
> Hello,
> 
> Thank you for reviewing v1.
> v2 contains the minimal changes.
> 
> Changes in v2 2025-11-12:
> - Move the required socket library from LINK_SPEC to the host file.
> Adding the
> library to LINK_SPEC leads to HAVE_GETHOSTNAME detection, which
> requires
> changes in the codebase.
> Validated by
> https://github.com/eukarpov/gnu-toolchain-windows-arm64/actions/runs/19301245653

Thanks; v2 looks good to me also.

Dave

> 
> v1 2025-11-12:
> [PATCH] diagnostics: add experimental SARIF JSON-RPC notifications
> for
> IDEs [PR115970]
> https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=8a155c170b443e332b3db4922f0f0d588a17604f
> introduces a regression when building the toolchain for the
> aarch64-w64-mingw32 host, at least. It is most likely the same for *-
> *-mingw32
> targets.
> This patch resolves the issue when using sockets for SARIF JSON-RPC
> notifications
> on MinGW host and adds the required socket library to LINK_SPEC.
> https://gcc.gnu.org/pipermail/gcc-patches/2025-November/700341.html
> 
> Regards,
> Evgeny
> 
> Evgeny Karpov (1):
>   Support experimental SARIF JSON-RPC notifications on MinGW host
> 
>  gcc/config/i386/x-mingw32     | 3 +++
>  gcc/diagnostics/sarif-sink.cc | 9 +++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 

Reply via email to