Hi Vijay,

Right now my comments are just limited to the spell check.

Fix the typo "elments" → "elements" before committing.

-  emit_insn (gen_vcmpne<VSX_EXTRACT_WIDTH> (cmpz1_result, operands[1], vzero));
-  emit_insn (gen_vcmpne<VSX_EXTRACT_WIDTH> (cmpz2_result, operands[2], vzero));
-  emit_insn (gen_and<mode>3 (and_result, cmpz1_result, cmpz2_result));
+  /* Vector with ones in elments that match or elements corresponding to zeros
+     in operands.  */

+  /* Vector with ones in elements that match or elements corresponding to zero

-  /* Vector with ones in elments that match.  */
-  emit_insn (gen_vcmpnez<VSX_EXTRACT_WIDTH> (cmpz_result, operands[1],
+  emit_insn (gen_vcmpnez<VSX_EXTRACT_WIDTH> (result, operands[1],


I am in the process of checking/verifying how vcmpez inherently handles the zero-checking that was previously explicit.

The patch looks good if vcmpnez (compare not equal or zero) already provides the combined functionality.

Thanks,

Manjunath S Matti.

Reply via email to