On 10/20/25 23:42, Jakub Jelinek wrote:

On Mon, Oct 20, 2025 at 11:39:29PM +0200, Josef Melcr wrote:
this patch addresses the incorrectly placed tests, which fail if the
testsuite is ran and gcc has not been installed yet, as discussed
here: https://gcc.gnu.org/pipermail/gcc-patches/2025-October/698095.html
The tests pass fine in their new location, though I wasn't able to
reproduce the issue on my system to begin with, so if somebody could
verify it, it would be much appreciated.

Best regards,
Josef

libgomp/ChangeLog:

        * gcc/testsuite/gcc.dg/ipa/ipcp-cb-spec1.c: Move to...
        * testsuite/libgomp.c/ipcp-cb-spec1.c: ...here.
        * gcc/testsuite/gcc.dg/ipa/ipcp-cb-spec2.c: Move to...
        * testsuite/libgomp.c/ipcp-cb-spec2.c: ...here.
        * gcc/testsuite/gcc.dg/ipa/ipcp-cb1.c: Move to...
        * testsuite/libgomp.c/ipcp-cb1.c: ...here.
You can't write a valid ChangeLog entry like that.
It needs to be
gcc/testsuite/ChangeLog:
        * gcc.dg/ipa/ipcp-cb-spec1.c: Move to libgomp/testsuite/libgomp.c/.
        * gcc.dg/ipa/ipcp-cb-spec2.c: Likewise.
        * gcc.dg/ipa/ipcp-cb1.c: Likewise.
libgomp/ChangeLog:
        * testsuite/libgomp.c/ipcp-cb-spec1.c: Moved from
        gcc/testsuite/gcc.dg/ipa/.
        * gcc.dg/ipa/ipcp-cb-spec2.c: Likewise.
        * gcc.dg/ipa/ipcp-cb1.c: Likewise.
because otherwise it won't pass the validation.
Oops, I just went with what the gcc-commit-mklog macro generated, thought it looked a bit weird.  I'll resend, sorry.
        Jakub

Josef

Reply via email to