Jonathan Wakely <[email protected]> writes: > On Mon, 13 Oct 2025 at 20:06, Joel Sherrill <[email protected]> wrote: >> >> RTEMS has carried this patch for too long and it was posted to gcc-patches >> last month. >> >> Any commits rom libstdc++ folks or is it OK to commit? >> >> Thanks. >> >> --joel >> >> On Wed, Oct 1, 2025 at 3:44 PM Joel Sherrill <[email protected]> wrote: >>> >>> From: Chris Johns <[email protected]> >>> >>> libstdc++-v3/ChangeLog: >>> >>> * configure: Regenerate. > > How was this regenerated? Because I see errors on trunk and gcc-15: > > autoheader_: warning: missing template: HAVE_SYS_IOCT4YL_H > autoheader_: Use AC_DEFINE([HAVE_SYS_IOCT4YL_H], [], [Description]) > autoheader_: warning: missing template: _GLIBCXX_USE_FDOPENDIR > autoheader_: warning: missing template: _GLIBCXX_USE_LINK > autoheader_: warning: missing template: _GLIBCXX_USE_READLINK > autoheader_: warning: missing template: _GLIBCXX_USE_SYMLINK > autoheader_: warning: missing template: _GLIBCXX_USE_TRUNCATE > autoreconf_: /opt/autotools-gcc/bin/autoheader_ failed with exit status: 1 > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122322
LGTM. > > > > >>> * configure.ac (newlib, *-rtems*): Add HAVE_SYS_IOCTL_H, >>> HAVE_SYS_STAT_H, HAVE_SYS_TYPES_H, HAVE_S_ISREG, HAVE_UNISTD_H, >>> HAVE_UNLINKAT, _GLIBCXX_USE_CHMOD, _GLIBCXX_USE_MKDIR, >>> _GLIBCXX_USE_CHDIR, _GLIBCXX_USE_GETCWD, _GLIBCXX_USE_UTIME, >>> _GLIBCXX_USE_LINK, _GLIBCXX_USE_READLINK, _GLIBCXX_USE_SYMLINK, >>> _GLIBCXX_USE_TRUNCATE and _GLIBCXX_USE_FDOPENDIR. > > Looking more closely, several of these are never needed by libstdc++, > so I'm not sure why they are being added here. And four of them were > added twice. > > I think the attached patch is needed (on trunk and gcc-15 and gcc14). > > [2. text/plain; patch.txt]...
