On Wed, Oct 08, 2025 at 06:07:34PM +0100, Jason Merrill wrote:
> > + /* Always construct signed integer vector type. */
> > + intt = c_common_type_for_size
> > + (GET_MODE_BITSIZE (SCALAR_TYPE_MODE (TREE_TYPE (type0)))
> > + , 0);
>
> We don't put a comma at the beginning of a line. And Emacs won't preserve
> that indentation of the (, it will move it to the left as with the old code.
> If you want the arguments to be aligned with the function name (as we
> generally try to do), please add parentheses around the whole call.
>
> Yes, it's awkward to fit long calls like this into 80 columns...
But in this case it would help to just introduce a temporary,
auto inttmode = SCALAR_TYPE_MODE (TREE_TYPE (type0));
intt = c_common_type_for_size (GET_MODE_BITSIZE (inttmode), 0);
>
> > + if (!intt)
> > + {
> > + if (complain & tf_error)
> > + error_at (location, "could not find an integer type "
> > + "of the same size as %qT", TREE_TYPE (type0));
> > + return error_mark_node;
> > + }
> > + result_type = build_opaque_vector_type
> > + (intt, TYPE_VECTOR_SUBPARTS (type0));
>
> Parens around the call here as well.
Or
result_type
= build_opaque_vector_type (intt,
TYPE_VECTOR_SUBPARTS (type0));
or again with some temporary,
auto subparts = TYPE_VECTOR_SUBPARTS (type0);
result_type = build_opaque_vector_type (intt, subparts);
Jakub
