Hi Marek, On Tue, Oct 14, 2025 at 11:26:53AM -0400, Marek Polacek wrote: > On Mon, Oct 13, 2025 at 09:40:37PM +0200, Alejandro Colomar wrote: > > Hi Marek, > > > > On Mon, Oct 13, 2025 at 03:30:36PM -0400, Marek Polacek wrote: > > > > +static void > > > > +warn_parm_array_mismatch (location_t origloc, rdwr_map *cur_idx, > > > > + rdwr_map *new_idx, tree curp, tree newp, > > > > + unsigned parmpos, bool builtin) > > > > > > Please add a comment if you're adding a new function. > > > > Ahh, sure. Do you have any suggestions? > > I'd be happy with something like > > /* Helper for warn_parms_array_mismatch. Compare the mappings of > two function parameters and diagnose mismatches. [and briefly > describe the parameters] */
Thanks! I was hoping you could describe the parameters. I understand what curp, newp, parmpos, and builtin are, but I don't understand very much cur_idx and new_idx. They look like pointers to the set of attributes for the pair of parameters being compared, but I don't see how it is being advanced, which is why I'm a bit confused. Have a lovely night! Alex -- <https://www.alejandro-colomar.es> Use port 80 (that is, <...:80/>).
signature.asc
Description: PGP signature
