4. Not sure if it would be better to change *return iota(...) *to *return views::iota(...)*.
Hewill Kang <[email protected]> 於 2025年10月14日 週二 下午11:32寫道： > 1. The prefix *ranges::* in *ranges::__detail::__is_integer_like* can be > removed. > 2. Parameters should not be passed by reference; otherwise, c*onst int i > = 0; std::views::indices(i);* will fail because *const int&* does not > satisfy *__is_integer_like*. > 3. operator() can be static. > > > > Yuao Ma <[email protected]> 於 2025年10月14日 週二 下午11:14寫道： > >> Hi Jonathan, >> >> On Tue, Oct 14, 2025 at 10:55 PM Jonathan Wakely <[email protected]> >> wrote: >> > Attaching patches as application/octet-stream makes them hard to >> > review and comment inline. If possible using 'git send-email' is the >> > ideal way to submit patches. If that's not possible (it can be awkward >> > to set up to send via gmail) then attaching a .txt file as text/plain >> > makes things easier for reviewers. >> > >> >> I'm attaching it as a txt file now; hopefully, this works. >> >> > Putting the [[nodiscard]] attribute after operator() was necessary in >> > previous releases of GCC due to -fconcepts-ts compatibility, but >> > that's no longer relevant for GCC 16. You can just put [[nodiscard]] >> > before the return type. >> > >> >> Done. >> >> > If you're contributing under the DCO terms then please don't add the >> > FSF copyright notice to new tests. And the test is not very novel or >> > interesting, so the licence text isn't needed either, see >> > >> https://gcc.gnu.org/onlinedocs/libstdc++/manual/test.html#test.new_tests >> > >> >> Thanks for the guidance. I've removed the copyright now. >> >> > >> > Also, I think this can be unconditionally noexcept. We know that >> > constructing iota_view from an integer-like type will not throw. >> > >> > For an arbitrary program-defined type that models weakly_incrementable >> > it could throw, but not for integer-like types. >> > >> >> Done. >> >> Thanks for the prompt review! >> Yuao >> >
