Re: [PATCH v2 4/5] xtensa: Change the splitting of D[IF]mode constant assignments to be implemented in xt_largeconst instead of define_split

[Max Filippov]

Hi Suwa-san,

On Mon, Sep 22, 2025 at 9:31 PM Takayuki 'January June' Suwa
<jjsuwa_sys3...@yahoo.co.jp> wrote:
> On 2025/09/23 2:42, Max Filippov wrote:
> > This change introduces the following new regressions:
> Ah, I was mistaken, split_DI_DF_const() is something that must be called if 
> necessary, not an optimization option.
>
> Also, applying this new patch will cause the subsequent "constantsynth v2" 
> patch to fail, so please change:
>
> >       if (optimize_enabled)
> >         split_DI_DF_const (insn);
>
> to:
>
> >       if (replacing_required)
> >         split_DI_DF_const (insn);
>
> and then apply it.

With this change there's still the following new regression:

FAIL: gfortran.dg/pr94285.f90   -O  (test for excess errors)
Excess errors:
gfortran: error:
/home/jcmvbkbc/ws/tensilica/gcc/gcc/gcc/testsuite/gfortran.dg/pr94285.f90:
'-fcompare-debug' failure

-- 
Thanks.
-- Max