Re: [PATCH v5 1/2] RISC-V: Fix can_find_related_mode_p for VLS types

[Kito Cheng]

On Mon, Sep 1, 2025 at 6:43 PM Robin Dapp <rdapp....@gmail.com> wrote:
>
>
> > @@ -3047,7 +3047,7 @@ can_find_related_mode_p (machine_mode vector_mode,
> > scalar_mode element_mode,
> >                    GET_MODE_SIZE (element_mode), nunits))
> >      return true;
> >    if (riscv_v_ext_vls_mode_p (vector_mode)
> > -      && multiple_p (TARGET_MIN_VLEN * TARGET_MAX_LMUL,
> > +      && multiple_p ((TARGET_MIN_VLEN * TARGET_MAX_LMUL) / 8,
> >                    GET_MODE_SIZE (element_mode), nunits))
>
> Just a very minor nit but instead of the / 8 could we not just use
> GET_MODE_PRECISION like e.g. vls_mode_valid_p?

I would prefer to keep it use GET_MODE_SIZE here since it make this
function more readable, I mean because few lines above just using
GET_MODE_SIZE, it might confusing people (at least to me :P) if we use
GET_MODE_PRECISION here.

>
> The rest looks reasonable to me.
>
> --
> Regards
>  Robin
>