On 7/27/25 11:00 AM, Aleksandar Rakic wrote:
Public
Hi,
I was going to apply this patch as it seems reasonable and independent
of everything else. But unfortunately it appears that you have munged
tabs into spaces.
While we could potentially use "-l" to ignore that problem and allow the
patch to apply, but then the resulting change would have munged the tabs
into spaces, which violates our coding styles.
For small isolated changes I don't mind fixing this stuff, but you have
dozens of changes and I don't have the time to fix each one you've
submitted.
It's not clear if the patch was munged by your mailer or in your local
tree, but it definitely needs to get resolved before these patches can
go forward.
Jeff
It seems that the original patch wasn't munged. I used DavMail to send the
original patch and verified its style using the contrib/check_GNU_style.sh
script located in the GCC source tree.
However, the ping was sent using Microsoft Outlook, which likely munged tabs
into spaces for some reason.
Could you please review the original patch from March 17, 2025, available at
the following link, and try applying it again:
https://sourceware.org/pipermail/gcc-patches/2025-March/677844.html
Done and pushed to the trunk. I don't have mips targets lit up in my
tester right now due to Jenkins issues from a couple weeks back. So I'm
flying a bit blind for MIPS stuff these days. Hopefully we don't muck
anything up.
So the natural question is how to proceed in the more general sense.
I'd really like to avoid having to find the old patch, verify it hasn't
changed, etc.
At the same time I understand you've been waiting a long time to move
things forward and don't want to waste your time.
Suggestions on how to deal with this efficiently?
Jeff
